Skip to content

Feat: Param aliases#61

Merged
lohanidamodar merged 5 commits intomainfrom
feat-param-aliases
May 5, 2026
Merged

Feat: Param aliases#61
lohanidamodar merged 5 commits intomainfrom
feat-param-aliases

Conversation

@Meldiron
Copy link
Copy Markdown
Contributor

@Meldiron Meldiron commented May 4, 2026

No description provided.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 4, 2026

Greptile Summary

  • Adds an aliases parameter to Action::param() and forwards it to all three hook initialisation paths (HTTP, CLI, Worker) via named argument — aliases: — keeping the call sites aligned with each other.
  • Dependency cleanup: all four utopia-php/* packages are now pinned to exact stable releases (addressing the previous dev-branch concern), utopia-php/fetch is dropped as a transitive dependency, and the PHP minimum is raised to 8.3 across both composer.json and the CI matrix.
  • Test coverage for the new field is solid on the HTTP path: aliases was added to the generic key-coverage loop and two targeted assertions verify aliased vs. non-aliased params.

Confidence Score: 5/5

Safe to merge — the change is minimal, well-tested on the HTTP path, and all prior review concerns have been addressed.

No P1 or P0 findings. Dependencies are now pinned to stable tagged releases, the aliases field flows correctly through all three platform initialisation paths, and the test suite was updated to cover both the generic key-contract loop and the specific alias values. No security-sensitive changes.

No files require special attention.

Important Files Changed

Filename Overview
src/Platform/Action.php Adds aliases as a new optional parameter to param(), stored in both $this->params and $this->options — straightforward and consistent with existing fields.
src/Platform/Platform.php Forwards aliases to $hook->param() via named argument in all three initialisation paths (HTTP, CLI, Worker); the ?? [] fallback is safe defensive coding.
tests/e2e/HTTPServicesTest.php Adds aliases to the generic key-coverage loop (addressing the prior outside-diff comment) and adds targeted assertions for both aliased and non-aliased params.
tests/Platform/TestActionWithParams.php Adds an email param with two aliases to exercise the new feature; callback signature updated accordingly.
composer.json Pins all four utopia dependencies to exact stable versions; dev-branch references from the previous review are gone.
.github/workflows/tests.yml Drops PHP 8.1 and 8.2 from the matrix, consistent with the updated composer.json minimum requirement of PHP >=8.3.

Reviews (5): Last reviewed commit: "Use stable param alias releases" | Re-trigger Greptile

Comment thread composer.json Outdated
Comment thread src/Platform/Platform.php
@lohanidamodar lohanidamodar merged commit a20cb8b into main May 5, 2026
5 checks passed
@lohanidamodar lohanidamodar deleted the feat-param-aliases branch May 5, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants